Skip to content

Commit

Permalink
Merge #49
Browse files Browse the repository at this point in the history
49: Run Miri on CI r=taiki-e a=taiki-e

The pin guarantees are guarantees of a library, so Miri does not detect
violations of the pin API. However, if the generated unsafe code causes
UB, Miri may be possible to detect it.

taiki-e/pin-project#288

Co-authored-by: Taiki Endo <te316e89@gmail.com>
  • Loading branch information
bors[bot] and taiki-e committed Jan 11, 2021
2 parents eb121b0 + b9ffe67 commit cd3413c
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 3 deletions.
10 changes: 10 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,15 @@ jobs:
run: cargo install -f cargo-expand --root ${{ runner.tool_cache }}/cargo-expand
- run: cargo test -p expandtest

miri:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: taiki-e/github-actions/install-rust@main
with:
component: miri
- run: cargo miri test --all

clippy:
runs-on: ubuntu-latest
steps:
Expand Down Expand Up @@ -127,6 +136,7 @@ jobs:
- test
- build
- expandtest
- miri
- clippy
- rustfmt
- rustdoc
Expand Down
1 change: 1 addition & 0 deletions tests/compiletest.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![cfg(not(miri))]
#![warn(rust_2018_idioms, single_use_lifetimes)]

use std::env;
Expand Down
1 change: 1 addition & 0 deletions tests/expand/tests/expandtest.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![cfg(not(miri))]
#![warn(rust_2018_idioms, single_use_lifetimes)]

use std::{
Expand Down
4 changes: 1 addition & 3 deletions tests/lint.rs
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@

// Check interoperability with rustc and clippy lints.

mod auxiliary;

pub mod basic {
include!("include/basic.rs");
}
Expand Down Expand Up @@ -239,7 +237,7 @@ pub mod clippy_used_underscore_binding {
}
}

mod clippy_ref_option_ref {
pub mod clippy_ref_option_ref {
use pin_project_lite::pin_project;

pin_project! {
Expand Down

0 comments on commit cd3413c

Please sign in to comment.