Fix trailing comma support in generics #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 950229c.
taiki-e
force-pushed
the
trailing-comma
branch
from
060656e
to
1f5f0e9
Compare
taiki-e
commented
Sep 29, 2020
Comment on lines
+427
to
+434
| // pin_project! { | ||
| // pub struct S4< | ||
| // 'a, | ||
| // 'b: 'a, // <----- | ||
| // > { | ||
| // f: &'a &'b (), | ||
| // } | ||
| // } |
There was a problem hiding this comment.
This code doesn't seem to compile even in previous versions.
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 950229c.
Fixes #31