feat: Add project_replace #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I will review it in detail next week, but overall it looks great! pin-project has 4 important tests on |
Marwes
force-pushed
the
project_replace
branch
from
3177cf0
to
e132c2c
Compare
taiki-e
approved these changes
Jan 9, 2021
|
✌️ Marwes can now approve this pull request. To approve and merge a pull request, simply reply with |
Marwes
force-pushed
the
project_replace
branch
2 times, most recently
from
490ed06
to
34b42bc
Compare
|
@Marwes Could you rebase and update the output of expandtest ( |
added 4 commits
January 10, 2021 13:06
To mirror the same method in [pin-project](https://docs.rs/pin-project/1.0.3/pin_project/). Currently this has to been specified explicitly via an attribute as it otherwise breaks on `!Sized` types.
Marwes
force-pushed
the
project_replace
branch
from
34b42bc
to
d17b34b
Compare
Marwes
force-pushed
the
project_replace
branch
from
d17b34b
to
cf30fc4
Compare
|
bors r+ |
|
Build succeeded: |
|
Published in 0.2.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To mirror the same method in pin-project.
Currently this has to been specified explicitly via an attribute as it
otherwise breaks on
!Sizedtypes.Could use some cleanup of the generated code and some tests around drop order (if possible) but other than that this did not seems to be as hard as I thought.
Closes #42