Determine the visibility based on the original type #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The visibility of the projected type and projection method is based on the original type. However, if the visibility of the original type is `pub`, the visibility of the projected type and the projection method is `pub(crate)`.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 15, 2019
5: Determine the visibility based on the original type r=taiki-e a=taiki-e The visibility of the projected type and projection method is based on the original type. However, if the visibility of the original type is `pub`, the visibility of the projected type and the projection method is `pub(crate)`. Based on taiki-e/pin-project#96 Co-authored-by: Taiki Endo <te316e89@gmail.com>
Build succeeded
|
taiki-e
added
the
C-enhancement
taiki-e
removed
the
C-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The visibility of the projected type and projection method is based on
the original type. However, if the visibility of the original type is
pub, the visibility of the projected type and the projection method ispub(crate).Based on taiki-e/pin-project#96