Support overwriting the name of core crate #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
force-pushed
the
overwriting-core-crate
branch
from
ea903b9
to
62f9627
Compare
|
bors r+ |
taiki-e
added
the
C-enhancement
|
Build succeeded: |
bors bot
added a commit
to taiki-e/pin-project-lite
that referenced
this pull request
May 7, 2020
14: Support overwriting the name of core crate r=taiki-e a=taiki-e taiki-e/pin-project#199 Co-authored-by: Taiki Endo <te316e89@gmail.com>
bors bot
added a commit
to taiki-e/futures-async-stream
that referenced
this pull request
May 7, 2020
53: Add test to make sure core crate overwrite works r=taiki-e a=taiki-e taiki-e/pin-project#199 Co-authored-by: Taiki Endo <te316e89@gmail.com>
taiki-e
removed
the
C-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rust-lang/pin-utils#26 (comment)
Note: If the proc-macro does not depend on its own items, it may be preferable not to
support overwriting the name of core/std crate for compatibility with reexport.