Add dry_run input option #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
commented
Oct 9, 2023
main.sh
Outdated
Comment on lines
54
to
55
| # TODO: Downgrade to info instead of warning because of more noise on | ||
| # https://github.com/<repo>/actions/runs/<id> page when set to warning? |
There was a problem hiding this comment.
Currently, the warnings are somewhat noisy if we have a lot of build matrix.
https://github.com/taiki-e/upload-rust-binary-action/actions/runs/6452798607
However, given the risk of making dry-run useless by missing a problem if there is no warning, we did not default to info (which is output in the log but is not very noticeable).
Perhaps adding another option to downgrade the warning might make sense.
|
Published in 1.17.0. Because of #56, this option is also available as |
taiki-e
added a commit
to taiki-e/cargo-hack
that referenced
this pull request
Oct 9, 2023
taiki-e
added a commit
to taiki-e/cargo-llvm-cov
that referenced
this pull request
Oct 9, 2023
taiki-e
added a commit
to taiki-e/cargo-no-dev-deps
that referenced
this pull request
Oct 9, 2023
taiki-e
added a commit
to taiki-e/cargo-minimal-versions
that referenced
this pull request
Oct 9, 2023
taiki-e
added a commit
to taiki-e/parse-changelog
that referenced
this pull request
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51
cc @MarcoIeni