fix(raiko): removed panic stabilization #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35359595
had a problem deploying
to
test-environment
GitHub Actions
Failure
johntaiko
force-pushed
the
chore/auto_logging
branch
from
f13e527
to
e24d7fc
Compare
|
I think check_eq doesn't propagate the error because no error is returned? So I think this would only log there is an error but would continue execution, which would be unexpected I think. |
petarvujovic98
requested changes
May 27, 2024
…/raiko into fix/removed_panic_stabilization
petarvujovic98
requested changes
May 28, 2024
petarvujovic98
approved these changes
May 28, 2024
Brechtpd
requested changes
May 30, 2024
petarvujovic98
requested changes
May 30, 2024
petarvujovic98
approved these changes
Jun 3, 2024
|
@Brechtpd Please take another look. |
Brechtpd
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing
assert_eqwithcheck_eq, which propagates error instead of panic.