Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge-ui): manual import not resetting correctly #16347

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

TheMindkiller
Copy link
Contributor

Observed behavior:

When you manually add a NFT and go back to the start, the contract address input remains
image
This blocks the UI, making interactions impossible without refresh!

Console output:

Uncaught (in promise) TypeError: Cannot set properties of undefined (setting 'value')
    at clearAddress (AddressInput.svelte:52:18)
    at AddressInput.svelte:73:5
    at run (chunk-4BDLA4GE.js?v=b5783581:30:10)
    at Array.forEach (<anonymous>)
    at run_all (chunk-4BDLA4GE.js?v=b5783581:36:7)
    at destroy_component (chunk-4BDLA4GE.js?v=b5783581:2150:5)
    at Object.destroy [as d] (ManualImport.svelte:192:39)
    at destroy_component (chunk-4BDLA4GE.js?v=b5783581:2151:32)
    at Object.destroy [as d] (ImportStep.svelte:16:40)
    at chunk-4BDLA4GE.js?v=b5783581:1408:17

Solution:
onDestroy() calls clearAddress(), but when it is not loaded it cannot reset the inputElement. So you should check if it exists.
Simple fix!

Go Taiko!! 馃

@dantaik dantaik enabled auto-merge March 7, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants