fix(bridge-ui): manual import not resetting correctly #16347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed behavior:
When you manually add a NFT and go back to the start, the contract address input remains
![image](https://private-user-images.githubusercontent.com/162104816/310685426-5b21ce74-4950-421a-aaa2-c87894c5d0b1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIwMTA1MDUsIm5iZiI6MTcyMjAxMDIwNSwicGF0aCI6Ii8xNjIxMDQ4MTYvMzEwNjg1NDI2LTViMjFjZTc0LTQ5NTAtNDIxYS1hYWEyLWM4Nzg5NGM1ZDBiMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzI2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyNlQxNjEwMDVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wOGQ5NWJjYzljNDk4MzJhMThiNmU3ZTY2Y2ViMzFiY2E1Y2UyMjY1YjQxYzViZTEwODViZDc1MWRmYzQyN2RkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.mnX-v865Ot4klPmKH57vqH7okPh4qjrMcls1RPEC1M0)
This blocks the UI, making interactions impossible without refresh!
Console output:
Solution:
onDestroy()
callsclearAddress()
, but when it is not loaded it cannot reset theinputElement
. So you should check if it exists.Simple fix!
Go Taiko!! 🥁