Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bridge): max amount button should deduct gas #12661

Merged
merged 7 commits into from
Jan 17, 2023
Merged

fix(bridge): max amount button should deduct gas #12661

merged 7 commits into from
Jan 17, 2023

Conversation

shadab-taiko
Copy link
Contributor

Fixes #11147

@shadab-taiko shadab-taiko linked an issue Jan 11, 2023 that may be closed by this pull request
fix(bridge): max amount leads to insufficient gas #11147
Closed
@shadab-taiko shadab-taiko marked this pull request as draft January 11, 2023 09:16
@codecov
Copy link

codecov bot commented Jan 16, 2023 •
edited
Loading

Codecov Report

Merging #12661 (9394989) into main (ac11959) will decrease coverage by 0.11%.
The diff coverage is 70.37%.

@@            Coverage Diff             @@
##             main   #12661      +/-   ##
==========================================
- Coverage   66.47%   66.36%   -0.12%     
==========================================
  Files         113      113              
  Lines        3034     3047      +13     
  Branches      356      357       +1     
==========================================
+ Hits         2017     2022       +5     
- Misses        941      949       +8     
  Partials       76       76
Flag Coverage Δ *Carryforward flag
bridge-ui 92.59% <70.37%> (-2.47%) ⬇️
protocol 59.23% <ø> (ø) Carriedforward from 223275c
relayer 69.10% <ø> (ø) Carriedforward from 223275c
ui 100.00% <100.00%> (ø) Carriedforward from 223275c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/bridge-ui/src/eth/bridge.ts 92.15% <66.66%> (-7.85%) ⬇️
packages/bridge-ui/src/erc20/bridge.ts 93.10% <73.33%> (-6.90%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cyberhorsey cyberhorsey marked this pull request as ready for review January 17, 2023 05:22
@dantaik dantaik merged commit 7692ac8 into main Jan 17, 2023
@dantaik dantaik deleted the fix-11147 branch January 17, 2023 11:10
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Merged
davidtaikocha pushed a commit that referenced this pull request Jan 18, 2023
@shadab-taiko @davidtaikocha
fix(bridge): max amount button should deduct gas (#12661)
870095b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dong77 dong77 dong77 approved these changes

@dantaik dantaik dantaik approved these changes

@cyberhorsey cyberhorsey cyberhorsey approved these changes

@RogerLamTd RogerLamTd Awaiting requested review from RogerLamTd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(bridge): max amount leads to insufficient gas
4 participants
@shadab-taiko @dong77 @dantaik @cyberhorsey