Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): re-implement bridge receive check #13134

Merged
merged 4 commits into from
Feb 10, 2023

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Feb 10, 2023

This implementation is slightly different from the previous implementation in that we all the resolve to return empty values. It does't has security issues compared to the previous one.
I also allow the owner() in the receive just in case.

Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #13134 (5967c3a) into main (95596e4) will increase coverage by 0.17%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #13134      +/-   ##
==========================================
+ Coverage   62.57%   62.74%   +0.17%     
==========================================
  Files         114      114              
  Lines        3220     3224       +4     
  Branches      435      439       +4     
==========================================
+ Hits         2015     2023       +8     
+ Misses       1129     1124       -5     
- Partials       76       77       +1     
Flag Coverage Δ *Carryforward flag
bridge-ui 92.61% <ø> (ø) Carriedforward from 95596e4
protocol 53.23% <0.00%> (+0.33%) ⬆️
relayer 69.15% <ø> (ø) Carriedforward from 95596e4
ui 100.00% <ø> (ø) Carriedforward from 95596e4

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/bridge/Bridge.sol 41.17% <0.00%> (-5.50%) ⬇️
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 90.36% <0.00%> (+7.22%) ⬆️
...ges/protocol/contracts/libs/LibAnchorSignature.sol 100.00% <0.00%> (+10.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik marked this pull request as ready for review February 10, 2023 06:09
@dantaik dantaik added this pull request to the merge queue Feb 10, 2023
Merged via the queue into main with commit 3c10706 Feb 10, 2023
@dantaik dantaik deleted the redo_receive_check_for_bridge branch February 10, 2023 06:41
@github-actions github-actions bot mentioned this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants