Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(protocol): avoid memory copy in _getInstance #13215

Merged
merged 2 commits into from
Feb 26, 2023
Merged

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Feb 26, 2023

No description provided.

@dantaik dantaik changed the title refactor(protocol): avoid memory copy refactor(protocol): avoid memory copy in _getInstance Feb 26, 2023
@dantaik dantaik marked this pull request as ready for review February 26, 2023 10:35
@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Merging #13215 (2d0f3dd) into main (9804099) will increase coverage by 0.17%.
The diff coverage is 15.38%.

@@            Coverage Diff             @@
##             main   #13215      +/-   ##
==========================================
+ Coverage   60.72%   60.89%   +0.17%     
==========================================
  Files         116      116              
  Lines        3521     3524       +3     
  Branches      483      483              
==========================================
+ Hits         2138     2146       +8     
+ Misses       1299     1293       -6     
- Partials       84       85       +1     
Flag Coverage Δ *Carryforward flag
bridge-ui 93.80% <ø> (ø) Carriedforward from 9804099
protocol 51.34% <15.38%> (+0.34%) ⬆️
relayer 65.15% <ø> (ø) Carriedforward from 9804099
ui 100.00% <ø> (ø) Carriedforward from 9804099

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/libs/LibProving.sol 0.00% <0.00%> (ø)
...es/protocol/contracts/test/libs/TestLibProving.sol 0.00% <0.00%> (ø)
...ackages/protocol/contracts/libs/LibBlockHeader.sol 92.30% <100.00%> (ø)
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 90.36% <0.00%> (+7.22%) ⬆️
...ges/protocol/contracts/libs/LibAnchorSignature.sol 100.00% <0.00%> (+10.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik added this pull request to the merge queue Feb 26, 2023
Merged via the queue into main with commit 72f9c1d Feb 26, 2023
@dantaik dantaik deleted the small_optimize branch February 26, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants