Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge-ui): handle wrong bridge address #13880

Merged
merged 21 commits into from Jun 5, 2023

Conversation

jscriptcoder
Copy link
Contributor

@jscriptcoder jscriptcoder commented Jun 5, 2023

Handling the problem of having old bridge address coming from the relayer API response.
Also small improvement in Transaction component

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #13880 (8c16859) into main (53bec14) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #13880      +/-   ##
==========================================
+ Coverage   51.37%   51.47%   +0.10%     
==========================================
  Files         143      143              
  Lines        3784     3792       +8     
  Branches      328      332       +4     
==========================================
+ Hits         1944     1952       +8     
  Misses       1726     1726              
  Partials      114      114              
Flag Coverage Δ *Carryforward flag
bridge-ui 94.27% <100.00%> (+0.05%) ⬆️
eventindexer 77.28% <ø> (ø) Carriedforward from ae199bf
protocol 0.00% <ø> (ø) Carriedforward from ae199bf
relayer 59.57% <ø> (ø) Carriedforward from ae199bf
ui 100.00% <ø> (ø) Carriedforward from ae199bf

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ges/bridge-ui/src/relayer-api/RelayerAPIService.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

davidtaikocha
davidtaikocha previously approved these changes Jun 5, 2023
@cyberhorsey cyberhorsey added this pull request to the merge queue Jun 5, 2023
Merged via the queue into main with commit fe425d9 Jun 5, 2023
9 checks passed
@cyberhorsey cyberhorsey deleted the handle_wrong_bridge_address branch June 5, 2023 19:01
@github-actions github-actions bot mentioned this pull request Jun 5, 2023
dantaik pushed a commit that referenced this pull request Jun 12, 2023
Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants