fix(bridge-ui): fix use max logic #13898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtaikocha
previously approved these changes
Jun 6, 2023
Codecov Report
@@ Coverage Diff @@
## main #13898 +/- ##
=======================================
Coverage 51.55% 51.55%
=======================================
Files 144 144
Lines 3798 3798
Branches 333 333
=======================================
Hits 1958 1958
Misses 1726 1726
Partials 114 114
*This pull request uses carry forward flags. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cyberhorsey
approved these changes
Jun 6, 2023
d1onys1us
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking on [max] button was throwing an exception for any token, ETH or ERC20, and never really calculating the max amount minus the gas needed for a transaction.