New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐳 feat(protocol): alpha-4 with staking-based tokenomics #14006
Conversation
adaki2004
commented
Jun 16, 2023
•
edited
edited
i think we can remove |
- Removed blk.prover != address(0) check in LibProposing.sol because blk.prover can be address(0) if for example the prover pool is out of capacity - Fix slashing check in LIbVerifying.sol in case blk.prover == address(0) - Fix failing tests - Removing tests which are not needed anymore (testOracleProverWithSignature, test_that_simple_oracle_prover_cannot_be_verified_only_if_normal_proof_comes_in)
Co-authored-by: Daniel Wang <dong77@gmail.com> Co-authored-by: adaki2004 <keszeydani@gmail.com> Co-authored-by: adaki2004 <adaki2004@users.noreply.github.com> Co-authored-by: D <51912515+adaki2004@users.noreply.github.com>
@dantaik @Brechtpd
IMO this is a good PoC/ working solution so we might want to ask @davidtaikocha and @cyberhorsey to proceed with the client so we will have something in our hand by end of this week. The less good news on the other hand is the gas consumption, comparison. The current alpha3 gas consumption as a benchmark: This version (with full list (32) of stakers/provers): This version (with 5 stakers/provers): Currently it raises 3-4x the @dantaik I guess there is room for some optimization, but would be great if you try it, to reserve the working mechanics/behavior of the code so we dont have to adjust the tests. I'll try to reach the (as close as possible) same behavior with the Brecht's proposed solution (tho the client interactions will differ a bit) but will give it a shot! |