Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bridge-ui-v2): transaction logic #14295

Merged
merged 12 commits into from
Jul 28, 2023
Merged

feat(bridge-ui-v2): transaction logic #14295

merged 12 commits into from
Jul 28, 2023

Conversation

jscriptcoder
Copy link
Contributor

@jscriptcoder jscriptcoder commented Jul 27, 2023 •
edited
Loading

Logic surrounded the bridge transaction and change of status

TODO: this is a more functional approach, but we might want to instead create a class BridgeTransaction with methods such as startPolling

@cyberhorsey cyberhorsey changed the title feat(briudge-ui-v2): transaction logic feat(bridge-ui-v2): transaction logic Jul 27, 2023
@jscriptcoder jscriptcoder marked this pull request as ready for review July 28, 2023 08:07
@jscriptcoder jscriptcoder self-assigned this Jul 28, 2023
@jscriptcoder jscriptcoder merged commit 580caf8 into feat/activities Jul 28, 2023
10 of 12 checks passed
@jscriptcoder jscriptcoder deleted the transaction_logic branch July 28, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KorbinianK KorbinianK KorbinianK approved these changes

@dantaik dantaik Awaiting requested review from dantaik

@davidtaikocha davidtaikocha Awaiting requested review from davidtaikocha

@xiaodino xiaodino Awaiting requested review from xiaodino

Assignees

@jscriptcoder jscriptcoder

Labels
area.bridge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jscriptcoder @KorbinianK @davidtaikocha