Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bridge-ui): ternary refactor #17023

Closed
wants to merge 1 commit into from
Closed

Conversation

kirillov13
Copy link

Ternary refactor

@kirillov13 kirillov13 changed the title chore(bridge-ui): Ternary refactor chore(bridge-ui): ternary refactor May 7, 2024
@KorbinianK
Copy link
Contributor

@kirillov13 have you actually tested your code? Because the approval checks are not working correctly...

Adding function calls to reactive statements in svelte 4 is not always ideal.
It's a bit clunky right now, I know, but once svelte 5 is out, things get better with runes and we can refactor then.

@KorbinianK KorbinianK closed this May 7, 2024
@kirillov13
Copy link
Author

@KorbinianK

Yes, I just tested it again and the code works correctly

I don't think there could be any problems with the functions, but I can do refactor without functions if you think it will be better

@KorbinianK
Copy link
Contributor

@kirillov13 I don't know what you tested but it doesn't work.
image

I don't have time to go through your code in more detail as there are more pressing matters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants