Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(taiko-client): improve progress tracker #17281

Merged
merged 9 commits into from
May 26, 2024
Merged

Conversation

davidtaikocha
Copy link
Contributor

No description provided.

@mask-pp
Copy link
Contributor

mask-pp commented May 22, 2024

Actually lastSyncedBlockID is used for recording the current syncing blockID, how about rename to lastSyncingBlockID?

Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 28.88889% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 49.88%. Comparing base (3c37890) to head (64f99dd).
Report is 9 commits behind head on main.

Current head 64f99dd differs from pull request most recent head a6efb27

Please upload reports for the commit a6efb27 to get more accurate results.

Files Patch % Lines
...ko-client/driver/chain_syncer/beaconsync/syncer.go 0.00% 19 Missing ⚠️
...driver/chain_syncer/beaconsync/progress_tracker.go 41.66% 7 Missing ⚠️
...s/taiko-client/driver/chain_syncer/chain_syncer.go 40.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17281      +/-   ##
==========================================
+ Coverage   48.91%   49.88%   +0.97%     
==========================================
  Files          56       56              
  Lines        5720     5757      +37     
==========================================
+ Hits         2798     2872      +74     
+ Misses       2620     2577      -43     
- Partials      302      308       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidtaikocha davidtaikocha added this pull request to the merge queue May 26, 2024
Merged via the queue into main with commit 5d05226 May 26, 2024
5 of 6 checks passed
@davidtaikocha davidtaikocha deleted the update-tracker branch May 26, 2024 03:09
davidtaikocha added a commit that referenced this pull request May 26, 2024
Co-authored-by: maskpp <maskpp266@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(taiko-client): stop triggering another round of beacon sync when the node is still syncing
3 participants