Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): fix getLastSyncedBlock by writing the block's verifiedTransitionId #17624

Merged
merged 16 commits into from
Jun 20, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jun 19, 2024

BEGIN_COMMIT_OVERRIDE
fix(protocol): fix getLastSyncedBlock by writing the block's verifiedTransitionId
fix(protocol): fix tip payment to L1 block builder
END_COMMIT_OVERRIDE

Now getLastSyncedBlock will return 0 for blockHash and stateRoot as the last synced block's verifiedTransitionId is not written.

@dantaik dantaik marked this pull request as ready for review June 19, 2024 12:40
Copy link

openzeppelin-code bot commented Jun 19, 2024

fix(protocol): fix getLastSyncedBlock by writing the block's verifiedTransitionId

Generated at commit: 537cb3a3122ef9c1adacf057416c71fb581b9d04

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
8
42
54
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik changed the title fix(protocol): fix getLastSyncedBlock by writing to the block's verifiedTransitionId fix(protocol): fix getLastSyncedBlock by writing the block's verifiedTransitionId Jun 19, 2024
@dantaik dantaik requested a review from swarna1101 June 20, 2024 04:54
@dantaik dantaik enabled auto-merge June 20, 2024 06:09
@dantaik dantaik disabled auto-merge June 20, 2024 06:25
@dantaik dantaik enabled auto-merge June 20, 2024 06:29
@dantaik dantaik added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit 6e07ab5 Jun 20, 2024
4 checks passed
@dantaik dantaik deleted the willSyncStateRoot branch June 20, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants