Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(protocol): i++ to ++i to reduce 5 gas #2033

Merged
merged 2 commits into from
Jan 3, 2023

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Dec 29, 2022

No description provided.

@dantaik dantaik marked this pull request as ready for review December 29, 2022 05:13
@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #2033 (52d35d7) into tokenomics_implementation (5788dd3) will not change coverage.
The diff coverage is 72.00%.

@@                    Coverage Diff                     @@
##           tokenomics_implementation    #2033   +/-   ##
==========================================================
  Coverage                      64.10%   64.10%           
==========================================================
  Files                            107      107           
  Lines                           2964     2964           
  Branches                         369      369           
==========================================================
  Hits                            1900     1900           
  Misses                           987      987           
  Partials                          77       77           
Flag Coverage Δ *Carryforward flag
bridge-ui 95.05% <ø> (ø) Carriedforward from 4d2cee0
protocol 54.40% <72.00%> (ø)
relayer 68.92% <ø> (ø) Carriedforward from 4d2cee0
ui 100.00% <ø> (ø) Carriedforward from 4d2cee0

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/libs/LibProving.sol 0.00% <0.00%> (ø)
...ckages/protocol/contracts/L1/libs/LibVerifying.sol 13.33% <0.00%> (ø)
packages/protocol/contracts/libs/LibTxDecoder.sol 84.53% <50.00%> (ø)
...es/protocol/contracts/thirdparty/LibBytesUtils.sol 68.75% <50.00%> (ø)
packages/protocol/contracts/L2/TaikoL2.sol 53.19% <100.00%> (ø)
packages/protocol/contracts/libs/LibTxUtils.sol 96.55% <100.00%> (ø)
...col/contracts/test/thirdparty/TestLibRLPReader.sol 33.33% <100.00%> (ø)
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 90.36% <100.00%> (ø)
...ges/protocol/contracts/thirdparty/LibRLPReader.sol 77.98% <100.00%> (ø)
...ges/protocol/contracts/thirdparty/LibRLPWriter.sol 90.69% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik changed the base branch from tokenomics_implementation to main December 29, 2022 05:17
@dantaik dantaik changed the base branch from main to tokenomics_implementation December 29, 2022 05:18
@cyberhorsey cyberhorsey merged commit 0cbe6db into tokenomics_implementation Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants