Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(protocol): clean up permission code (whitelisting disabled) #2096

Merged
merged 3 commits into from
Jan 3, 2023

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Dec 29, 2022

The next test net will be permissionless.

@dantaik dantaik marked this pull request as ready for review December 29, 2022 06:47
@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #2096 (360b037) into tokenomics_implementation (5788dd3) will increase coverage by 0.94%.
The diff coverage is n/a.

@@                      Coverage Diff                      @@
##           tokenomics_implementation    #2096      +/-   ##
=============================================================
+ Coverage                      64.10%   65.04%   +0.94%     
=============================================================
  Files                            107      107              
  Lines                           2964     2918      -46     
  Branches                         369      357      -12     
=============================================================
- Hits                            1900     1898       -2     
+ Misses                           987      943      -44     
  Partials                          77       77              
Flag Coverage Δ *Carryforward flag
bridge-ui 95.05% <ø> (ø) Carriedforward from 5788dd3
protocol 55.96% <ø> (+1.55%) ⬆️
relayer 68.92% <ø> (ø) Carriedforward from 5788dd3
ui 100.00% <ø> (ø) Carriedforward from 5788dd3

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/TaikoL1.sol 22.44% <ø> (+2.13%) ⬆️
...ckages/protocol/contracts/L1/libs/LibProposing.sol 0.00% <ø> (ø)
packages/protocol/contracts/L1/libs/LibProving.sol 0.00% <ø> (ø)
packages/protocol/contracts/L1/libs/LibUtils.sol 4.68% <ø> (+1.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik merged commit 972f527 into tokenomics_implementation Jan 3, 2023
@dantaik dantaik deleted the clean_up_permission branch January 3, 2023 04:49
@gitpoap-bot
Copy link

gitpoap-bot bot commented Jan 3, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Taiko Contributor:

GitPOAP: 2023 Taiko Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants