Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(relayer): add additional test coverage #291

Merged
merged 8 commits into from
Nov 19, 2022
Merged

chore(relayer): add additional test coverage #291

merged 8 commits into from
Nov 19, 2022

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented Nov 18, 2022

This MR enables only subscribing via cli flags, not indexing or processing old blocks, which is very useful for testing locally with the bridge UI in particular.

It also adds some interface separation to the various services, mocks for those, and bumps test coverage quite a bit in the process.

@vercel
Copy link

vercel bot commented Nov 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
website ⬜️ Ignored (Inspect) Nov 19, 2022 at 4:34AM (UTC)

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #291 (91efdf7) into main (7ad7fdf) will increase coverage by 13.40%.
The diff coverage is 62.50%.

@@             Coverage Diff             @@
##             main     #291       +/-   ##
===========================================
+ Coverage   54.40%   67.80%   +13.40%     
===========================================
  Files          23       23               
  Lines         976      994       +18     
===========================================
+ Hits          531      674      +143     
+ Misses        400      249      -151     
- Partials       45       71       +26     
Flag Coverage Δ
relayer 67.80% <62.50%> (+13.40%) ⬆️
Impacted Files Coverage Δ
packages/relayer/cli/cli.go 62.44% <0.00%> (ø)
packages/relayer/indexer/service.go 79.31% <ø> (ø)
packages/relayer/message/processor.go 100.00% <ø> (ø)
packages/relayer/proof/encoded_signal_proof.go 50.00% <ø> (ø)
packages/relayer/proof/types.go 90.00% <ø> (ø)
packages/relayer/indexer/filter_then_subscribe.go 20.00% <50.00%> (+20.00%) ⬆️
packages/relayer/indexer/subscribe.go 86.48% <70.00%> (+86.48%) ⬆️
packages/relayer/indexer/handle_event.go 50.00% <100.00%> (+23.61%) ⬆️
packages/relayer/message/process_message.go 67.54% <100.00%> (+67.54%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

dantaik
dantaik previously approved these changes Nov 19, 2022
@dantaik dantaik changed the title chore(relayer): addtl test coverage chore(relayer): add additional test coverage Nov 19, 2022
cyberhorsey and others added 2 commits November 18, 2022 20:34
Co-authored-by: David <104078303+davidtaikocha@users.noreply.github.com>
@dantaik dantaik merged commit a1a1d65 into main Nov 19, 2022
@dantaik dantaik deleted the subscribe branch November 19, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants