Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(protocol): replace finalize with verify #298

Merged
merged 11 commits into from
Nov 22, 2022
Merged

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Nov 20, 2022

Now we refer "onchain finalized" as "verified". This PR replace "finalize" with "verify".

V1Finalizing.sol remains unchanged to make it easier to merge other PRs. This fill will be renamed later in a separate PR.

@dantaik dantaik changed the title Finalize -> Verify refactor(all): finalize -> verify Nov 20, 2022
@dantaik dantaik requested review from d1onys1us, davidtaikocha and cyberhorsey and removed request for davidtaikocha November 20, 2022 06:48
@dantaik dantaik marked this pull request as ready for review November 20, 2022 06:48
@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Merging #298 (8797388) into main (06ceee2) will increase coverage by 0.21%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
+ Coverage   63.35%   63.56%   +0.21%     
==========================================
  Files          79       81       +2     
  Lines        2377     2388      +11     
  Branches      269      270       +1     
==========================================
+ Hits         1506     1518      +12     
+ Misses        803      802       -1     
  Partials       68       68              
Flag Coverage Δ *Carryforward flag
protocol 59.77% <25.00%> (+0.40%) ⬆️
relayer 68.57% <ø> (ø) Carriedforward from 3fb5292

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/v1/V1Proposing.sol 0.00% <ø> (ø)
packages/protocol/contracts/L1/v1/V1Proving.sol 0.00% <ø> (ø)
packages/protocol/contracts/L2/V1TaikoL2.sol 56.81% <ø> (ø)
...protocol/contracts/bridge/libs/LibBridgeSignal.sol 86.95% <ø> (+17.39%) ⬆️
.../protocol/contracts/test/bridge/TestHeaderSync.sol 0.00% <0.00%> (ø)
packages/protocol/contracts/L1/v1/V1Finalizing.sol 23.07% <12.50%> (ø)
packages/protocol/contracts/L1/TaikoL1.sol 19.51% <16.66%> (ø)
packages/protocol/contracts/L1/LibData.sol 21.42% <33.33%> (ø)
...ontracts/test/bridge/libs/TestLibBridgeProcess.sol 100.00% <100.00%> (ø)
...rotocol/contracts/bridge/libs/LibBridgeProcess.sol 23.52% <0.00%> (+11.76%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik linked an issue Nov 20, 2022 that may be closed by this pull request
@dantaik dantaik self-assigned this Nov 20, 2022
@dantaik dantaik changed the title refactor(all): finalize -> verify refactor(protocol): finalize -> verify Nov 20, 2022
@dantaik dantaik changed the title refactor(protocol): finalize -> verify refactor(protocol): step 2 - replace finalize with verify Nov 20, 2022
davidtaikocha
davidtaikocha previously approved these changes Nov 20, 2022
Base automatically changed from disable-codecov-project-patch to main November 21, 2022 04:53
@dantaik dantaik changed the title refactor(protocol): step 2 - replace finalize with verify refactor(protocol): replace finalize with verify Nov 22, 2022
@dantaik dantaik merged commit 5c4d370 into main Nov 22, 2022
@dantaik dantaik deleted the finalize_to_verify branch November 22, 2022 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[protocol] Replace "finalize" with "verify" in the core protocol code
4 participants