-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(protocol): replace finalize
with verify
#298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #298 +/- ##
==========================================
+ Coverage 63.35% 63.56% +0.21%
==========================================
Files 79 81 +2
Lines 2377 2388 +11
Branches 269 270 +1
==========================================
+ Hits 1506 1518 +12
+ Misses 803 802 -1
Partials 68 68
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
finalize
-> verify
finalize
-> verify
finalize
-> verify
finalize
with verify
davidtaikocha
previously approved these changes
Nov 20, 2022
davidtaikocha
approved these changes
Nov 21, 2022
d1onys1us
approved these changes
Nov 21, 2022
Brechtpd
approved these changes
Nov 21, 2022
finalize
with verify
finalize
with verify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we refer "onchain finalized" as "verified". This PR replace "finalize" with "verify".
V1Finalizing.sol remains unchanged to make it easier to merge other PRs. This fill will be renamed later in a separate PR.