Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): Refactoring fixture() pattern to before/beforeEach pattern for tests #451

Merged
merged 9 commits into from
Dec 18, 2022

Conversation

RogerLamTd
Copy link
Contributor

No description provided.

@RogerLamTd RogerLamTd self-assigned this Dec 17, 2022
@RogerLamTd RogerLamTd linked an issue Dec 17, 2022 that may be closed by this pull request
@RogerLamTd RogerLamTd marked this pull request as ready for review December 17, 2022 10:15
@RogerLamTd
Copy link
Contributor Author

RogerLamTd commented Dec 17, 2022

All relevant unit tests have been converted from fixture to before/beforeEach.

RogerLamTd and others added 2 commits December 17, 2022 18:34
Co-authored-by: David <104078303+davidtaikocha@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Dec 17, 2022

Codecov Report

Merging #451 (c8bef38) into main (31584b4) will increase coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #451      +/-   ##
==========================================
+ Coverage   66.12%   66.48%   +0.35%     
==========================================
  Files         102      102              
  Lines        2787     2787              
  Branches      328      328              
==========================================
+ Hits         1843     1853      +10     
+ Misses        871      860      -11     
- Partials       73       74       +1     
Flag Coverage Δ *Carryforward flag
bridge-ui 99.10% <ø> (ø) Carriedforward from 31584b4
protocol 58.97% <ø> (+0.71%) ⬆️
relayer 68.92% <ø> (ø) Carriedforward from 31584b4
ui 100.00% <ø> (ø) Carriedforward from 31584b4

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 90.36% <0.00%> (+7.22%) ⬆️
...contracts/test/bridge/libs/TestLibBridgeSignal.sol 100.00% <0.00%> (+100.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RogerLamTd RogerLamTd merged commit 19de694 into main Dec 18, 2022
@RogerLamTd RogerLamTd deleted the testfixtures branch December 18, 2022 03:49
@gitpoap-bot
Copy link

gitpoap-bot bot commented Dec 18, 2022

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Taiko Contributor:

GitPOAP: 2022 Taiko Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

fix(test): change test fixtures into before/beforeEach blocks
3 participants