Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge): fix max amount button #6246

Merged
merged 5 commits into from
Jan 3, 2023
Merged

fix(bridge): fix max amount button #6246

merged 5 commits into from
Jan 3, 2023

Conversation

shadab-taiko
Copy link
Contributor

Fixes #2743

@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Merging #6246 (50d65bf) into main (197ae01) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6246   +/-   ##
=======================================
  Coverage   66.79%   66.79%           
=======================================
  Files         106      106           
  Lines        2843     2843           
  Branches      354      354           
=======================================
  Hits         1899     1899           
  Misses        868      868           
  Partials       76       76           
Flag Coverage Δ *Carryforward flag
bridge-ui 95.05% <ø> (ø)
protocol 58.88% <ø> (ø) Carriedforward from 197ae01
relayer 69.10% <ø> (ø) Carriedforward from 197ae01
ui 100.00% <ø> (ø) Carriedforward from 197ae01

*This pull request uses carry forward flags. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

d1onys1us
d1onys1us previously approved these changes Jan 2, 2023
@dantaik
Copy link
Contributor

dantaik commented Jan 3, 2023

@shadab-taiko can we make sure the accuracy of the max value fixed? For example, 4 decimals.

@vercel
Copy link

vercel bot commented Jan 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
website 🔄 Building (Inspect) Jan 3, 2023 at 8:31AM (UTC)

@shadab-taiko shadab-taiko merged commit 409e7a4 into main Jan 3, 2023
@shadab-taiko shadab-taiko deleted the fix-2743 branch January 3, 2023 12:36
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(bridge-ui): Max features not working properly
3 participants