Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(protocol): extract IProofVerifier interface #6800

Merged
merged 15 commits into from
Jan 3, 2023

Conversation

dong77
Copy link
Contributor

@dong77 dong77 commented Jan 3, 2023

Extract an IVerifier interface so we can mock it in tests.

@vercel
Copy link

vercel bot commented Jan 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
bridge-ui 🔄 Building (Inspect) Jan 3, 2023 at 3:09PM (UTC)
website 🔄 Building (Inspect) Jan 3, 2023 at 3:09PM (UTC)

@dong77 dong77 changed the title refactor(protocol): verifer contract refactor(protocol): extract ProofVerifier interface Jan 3, 2023
@dong77 dong77 changed the title refactor(protocol): extract ProofVerifier interface refactor(protocol): extract IProofVerifier interface Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #6800 (dde6012) into tokenomics_implementation (0cbe6db) will increase coverage by 0.11%.
The diff coverage is 0.00%.

@@                      Coverage Diff                      @@
##           tokenomics_implementation    #6800      +/-   ##
=============================================================
+ Coverage                      64.77%   64.88%   +0.11%     
=============================================================
  Files                            107      108       +1     
  Lines                           2918     2925       +7     
  Branches                         357      355       -2     
=============================================================
+ Hits                            1890     1898       +8     
+ Misses                           952      950       -2     
- Partials                          76       77       +1     
Flag Coverage Δ *Carryforward flag
bridge-ui 95.05% <ø> (ø) Carriedforward from 0cbe6db
protocol 55.69% <0.00%> (+0.27%) ⬆️
relayer 68.92% <ø> (ø) Carriedforward from 0cbe6db
ui 100.00% <ø> (ø) Carriedforward from 0cbe6db

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/ProofVerifier.sol 0.00% <0.00%> (ø)
packages/protocol/contracts/L1/libs/LibProving.sol 0.00% <0.00%> (ø)
...ckages/protocol/contracts/libs/LibSharedConfig.sol 0.00% <ø> (ø)
packages/protocol/contracts/libs/LibZKP.sol 0.00% <ø> (ø)
...ackages/protocol/contracts/test/L1/TestTaikoL1.sol 0.00% <0.00%> (ø)
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 90.36% <0.00%> (+7.22%) ⬆️
...ges/protocol/contracts/libs/LibAnchorSignature.sol 100.00% <0.00%> (+10.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik requested review from dantaik, cyberhorsey and davidtaikocha and removed request for dantaik January 3, 2023 12:12
@dantaik dantaik merged commit 470afdf into tokenomics_implementation Jan 3, 2023
@dantaik dantaik deleted the core_protocol_unit_tests_1 branch January 3, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants