Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Enhance implementation of @call #1285

Closed
tusharmath opened this issue Mar 4, 2024 · 9 comments · Fixed by #1632
Closed

refactor: Enhance implementation of @call #1285

tusharmath opened this issue Mar 4, 2024 · 9 comments · Fixed by #1632

Comments

@tusharmath
Copy link
Contributor

tusharmath commented Mar 4, 2024

The current implementation of call handles each IO type viz. HTTP, gRPC, GraphQL, and Const, specifically. This means every time we add a new IO, we need to go here and make a change.

Proposal
Use Expression::Push_Args to set the args for the for the call operator. This should make the call::compile_call function significantly easier.

@tusharmath tusharmath changed the title TODO: Enhance implementation of @call refactor: Enhance implementation of @call Mar 4, 2024
@ologbonowiwi
Copy link
Contributor

ologbonowiwi commented Mar 7, 2024

I attempted to accomplish this on feat/#846/create-call-operator-via-resolver-with-arg, in case it helps.

It's not working, but can be taken inspiration from.

@tusharmath
Copy link
Contributor Author

Can do it after this — #1484

/bounty 150

Copy link

algora-pbc bot commented Mar 17, 2024

💎 $150 bounty created by tailcallhq
🙋 If you start working on this, comment /attempt #1285 along with your implementation plan
👉 To claim this bounty, submit a pull request that includes the text /claim #1285 somewhere in its body

🙏 Thank you for contributing to tailcallhq/tailcall!.
🧐 Checkout our guidelines before you get started.

Attempt Started (GMT+0) Solution
🔴 @ssddOnTop Mar 17, 2024, 9:34:32 AM WIP
🟢 @ologbonowiwi #1632

@ssddOnTop
Copy link
Member

ssddOnTop commented Mar 17, 2024

/attempt 1285

Algora profile Completed bounties Tech Active attempts Options
@ssddOnTop 24 tailcallhq bounties
Rust, Java,
C & more
Cancel attempt

@tusharmath
Copy link
Contributor Author

Use the with_args operator defined here on Expression https://github.com/tailcallhq/tailcall/pull/1485/files

@tusharmath
Copy link
Contributor Author

@ologbonowiwi Feel free to pick this one up. @ssddOnTop I think you should drop this one since you have a lot on your plate already.

Copy link

algora-pbc bot commented Apr 2, 2024

💡 @ologbonowiwi submitted a pull request that claims the bounty. You can visit your bounty board to reward.

ologbonowiwi added a commit to ologbonowiwi/tailcall that referenced this issue Apr 2, 2024
ologbonowiwi pushed a commit to ologbonowiwi/tailcall that referenced this issue Apr 2, 2024
…thub.com:ologbonowiwi/tailcall into feat/tailcallhq#1285/enhance-call-implementation
tusharmath added a commit to ologbonowiwi/tailcall that referenced this issue Apr 3, 2024
ologbonowiwi pushed a commit to ologbonowiwi/tailcall that referenced this issue Apr 3, 2024
ologbonowiwi pushed a commit to ologbonowiwi/tailcall that referenced this issue Apr 3, 2024
…thub.com:ologbonowiwi/tailcall into feat/tailcallhq#1285/enhance-call-implementation
Copy link

algora-pbc bot commented Apr 3, 2024

@ologbonowiwi: You've been awarded a $150 bounty by tailcallhq! We'll notify you once it is processed.

Copy link

algora-pbc bot commented Apr 3, 2024

🎉🎈 @ologbonowiwi has been awarded $150! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants