Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restructure workspace #1887

Merged
merged 52 commits into from
May 9, 2024

Conversation

laststylebender14
Copy link
Contributor

Summary:
restructured the workspace into following structure

src
  - cli/
  - core/
  - main.rs
  - lib.rs

Issue Reference(s):
Fixes #1853
Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

laststylebender14 and others added 30 commits May 6, 2024 12:50
- removed fail as it's not being used anywhere.
@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label May 7, 2024
@laststylebender14 laststylebender14 marked this pull request as draft May 7, 2024 14:57
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 89.72%. Comparing base (940513f) to head (fe35af0).

Files Patch % Lines
src/core/http/cache.rs 90.00% 3 Missing ⚠️
src/core/generator/source.rs 90.00% 1 Missing ⚠️
src/core/http/showcase.rs 80.00% 1 Missing ⚠️
src/core/lambda/expression.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1887      +/-   ##
==========================================
+ Coverage   89.68%   89.72%   +0.04%     
==========================================
  Files         154      154              
  Lines       15840    15817      -23     
==========================================
- Hits        14206    14192      -14     
+ Misses       1634     1625       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laststylebender14 laststylebender14 marked this pull request as ready for review May 8, 2024 08:10
@tusharmath tusharmath added the ci: benchmark Runs benchmarks label May 9, 2024
@tusharmath tusharmath enabled auto-merge (squash) May 9, 2024 06:45
@tusharmath tusharmath merged commit b74f247 into tailcallhq:main May 9, 2024
33 checks passed
Copy link

github-actions bot commented May 9, 2024

🐰Bencher

ReportThu, May 9, 2024 at 06:56:26 UTC
Projecttailcall
Branch1887/merge
Testbedbenchmarking-runner
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
group_by✅ (view plot)603.81 (-0.62%)633.07 (95.38%)
input/args.missing✅ (view plot)23.23 (-7.85%)26.82 (86.60%)
input/args.nested.existing✅ (view plot)40.59 (-26.09%)64.19 (63.22%)
input/args.nested.missing✅ (view plot)37.78 (-2.62%)40.15 (94.11%)
input/args.root✅ (view plot)38.99 (-24.42%)60.11 (64.87%)
input/headers.existing✅ (view plot)31.47 (-0.57%)32.70 (96.24%)
input/headers.missing✅ (view plot)30.70 (+0.64%)31.92 (96.19%)
input/value.missing✅ (view plot)23.25 (-1.29%)25.07 (92.74%)
input/value.nested.existing✅ (view plot)41.68 (+0.90%)43.14 (96.61%)
input/value.nested.missing✅ (view plot)38.06 (+5.19%)38.07 (100.00%)
input/value.root✅ (view plot)38.13 (-1.49%)39.95 (95.44%)
input/vars.existing✅ (view plot)7.50 (-9.83%)8.98 (83.54%)
input/vars.missing✅ (view plot)8.67 (+6.75%)8.94 (96.96%)
test_batched_body✅ (view plot)2,757.20 (-99.75%)2,834,000.42 (0.10%)
test_batched_body #2✅ (view plot)1,720,600.00 (-3.23%)1,905,976.19 (90.27%)
test_data_loader✅ (view plot)476,110.00 (+0.53%)490,979.89 (96.97%)
with_mustache_expressions✅ (view plot)1,153.50 (-1.63%)1,236.21 (93.31%)
with_mustache_literal✅ (view plot)718.45 (-0.48%)762.15 (94.27%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: benchmark Runs benchmarks type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create a core module
2 participants