Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move the skip marker into the heading #1920

Merged
merged 1 commit into from
May 12, 2024
Merged

Conversation

ssddOnTop
Copy link
Member

@ssddOnTop ssddOnTop commented May 12, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #1919
/claim 1919
/split 10% @mehulmathur16

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label May 12, 2024
@ssddOnTop ssddOnTop marked this pull request as ready for review May 12, 2024 11:38
Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.72%. Comparing base (6fbeebc) to head (aa760be).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1920      +/-   ##
==========================================
- Coverage   89.73%   89.72%   -0.01%     
==========================================
  Files         154      154              
  Lines       15817    15817              
==========================================
- Hits        14193    14192       -1     
- Misses       1624     1625       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tusharmath tusharmath merged commit b1c49f5 into main May 12, 2024
34 of 36 checks passed
@tusharmath tusharmath deleted the chore/refactor-skip branch May 12, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: move the skip marker into the heading
2 participants