Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replacing DefaultHasher #1926

Merged
merged 13 commits into from
May 13, 2024
Merged

fix: replacing DefaultHasher #1926

merged 13 commits into from
May 13, 2024

Conversation

shashitnak
Copy link
Contributor

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@shashitnak shashitnak added the ci: benchmark Runs benchmarks label May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.73%. Comparing base (ad2fbad) to head (e52aa8a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1926   +/-   ##
=======================================
  Coverage   89.73%   89.73%           
=======================================
  Files         154      155    +1     
  Lines       15831    15837    +6     
=======================================
+ Hits        14206    14212    +6     
  Misses       1625     1625           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 13, 2024

🐰Bencher

ReportMon, May 13, 2024 at 13:49:05 UTC
Projecttailcall
Branch1926/merge
Testbedbenchmarking-runner

🚨 1 ALERT: Threshold Boundary Limit exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
input/args.missingLatency (nanoseconds (ns))🚨 (view plot | view alert)28.48 (+13.75%)27.13 (104.98%)

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
group_by✅ (view plot)589.51 (-2.92%)632.06 (93.27%)
input/args.missing🚨 (view plot | view alert)28.48 (+13.75%)27.13 (104.98%)
input/args.nested.existing✅ (view plot)41.22 (-23.26%)65.51 (62.92%)
input/args.nested.missing✅ (view plot)37.56 (-2.89%)40.73 (92.22%)
input/args.root✅ (view plot)38.84 (-22.85%)61.69 (62.97%)
input/headers.existing✅ (view plot)31.48 (-0.96%)33.31 (94.51%)
input/headers.missing✅ (view plot)30.48 (-0.74%)32.81 (92.89%)
input/value.missing✅ (view plot)23.13 (-1.89%)25.30 (91.41%)
input/value.nested.existing✅ (view plot)42.63 (+2.96%)43.59 (97.80%)
input/value.nested.missing✅ (view plot)37.12 (+2.26%)38.22 (97.12%)
input/value.root✅ (view plot)38.09 (-1.50%)40.02 (95.17%)
input/vars.existing✅ (view plot)7.74 (-6.31%)9.01 (85.97%)
input/vars.missing✅ (view plot)8.10 (-0.16%)8.89 (91.03%)
test_batched_body✅ (view plot)2,675.60 (-99.73%)2,774,126.77 (0.10%)
test_batched_body #2✅ (view plot)1,696,600.00 (-3.77%)1,893,388.52 (89.61%)
test_data_loader✅ (view plot)452,790.00 (-4.35%)490,747.50 (92.27%)
test_handle_request✅ (view plot)169,130.00 (-2.33%)183,219.17 (92.31%)
with_mustache_expressions✅ (view plot)1,189.90 (+1.29%)1,238.52 (96.07%)
with_mustache_literal✅ (view plot)747.55 (+3.35%)765.27 (97.68%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@shashitnak shashitnak marked this pull request as ready for review May 13, 2024 13:23
@tusharmath tusharmath changed the title perf: replacing DefaultHasher with FnvHasher fix: replacing DefaultHasher with FnvHasher May 13, 2024
@tusharmath tusharmath changed the title fix: replacing DefaultHasher with FnvHasher fix: replacing DefaultHasher May 13, 2024
@tusharmath tusharmath enabled auto-merge (squash) May 13, 2024 13:32
@tusharmath tusharmath added the type: fix Iterations on existing features or infrastructure. label May 13, 2024
@tusharmath tusharmath merged commit 8b6db44 into main May 13, 2024
32 of 35 checks passed
@tusharmath tusharmath deleted the fnv-hasher branch May 13, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: benchmark Runs benchmarks type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants