-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replacing DefaultHasher
#1926
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1926 +/- ##
=======================================
Coverage 89.73% 89.73%
=======================================
Files 154 155 +1
Lines 15831 15837 +6
=======================================
+ Hits 14206 14212 +6
Misses 1625 1625 ☔ View full report in Codecov by Sentry. |
|
Report | Mon, May 13, 2024 at 13:49:05 UTC |
Project | tailcall |
Branch | 1926/merge |
Testbed | benchmarking-runner |
🚨 1 ALERT: Threshold Boundary Limit exceeded!
Benchmark | Measure (units) | View | Value | Lower Boundary | Upper Boundary |
---|---|---|---|---|---|
input/args.missing | Latency (nanoseconds (ns)) | 🚨 (view plot | view alert) | 28.48 (+13.75%) | 27.13 (104.98%) |
Click to view all benchmark results
Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
---|---|---|---|
group_by | ✅ (view plot) | 589.51 (-2.92%) | 632.06 (93.27%) |
input/args.missing | 🚨 (view plot | view alert) | 28.48 (+13.75%) | 27.13 (104.98%) |
input/args.nested.existing | ✅ (view plot) | 41.22 (-23.26%) | 65.51 (62.92%) |
input/args.nested.missing | ✅ (view plot) | 37.56 (-2.89%) | 40.73 (92.22%) |
input/args.root | ✅ (view plot) | 38.84 (-22.85%) | 61.69 (62.97%) |
input/headers.existing | ✅ (view plot) | 31.48 (-0.96%) | 33.31 (94.51%) |
input/headers.missing | ✅ (view plot) | 30.48 (-0.74%) | 32.81 (92.89%) |
input/value.missing | ✅ (view plot) | 23.13 (-1.89%) | 25.30 (91.41%) |
input/value.nested.existing | ✅ (view plot) | 42.63 (+2.96%) | 43.59 (97.80%) |
input/value.nested.missing | ✅ (view plot) | 37.12 (+2.26%) | 38.22 (97.12%) |
input/value.root | ✅ (view plot) | 38.09 (-1.50%) | 40.02 (95.17%) |
input/vars.existing | ✅ (view plot) | 7.74 (-6.31%) | 9.01 (85.97%) |
input/vars.missing | ✅ (view plot) | 8.10 (-0.16%) | 8.89 (91.03%) |
test_batched_body | ✅ (view plot) | 2,675.60 (-99.73%) | 2,774,126.77 (0.10%) |
test_batched_body #2 | ✅ (view plot) | 1,696,600.00 (-3.77%) | 1,893,388.52 (89.61%) |
test_data_loader | ✅ (view plot) | 452,790.00 (-4.35%) | 490,747.50 (92.27%) |
test_handle_request | ✅ (view plot) | 169,130.00 (-2.33%) | 183,219.17 (92.31%) |
with_mustache_expressions | ✅ (view plot) | 1,189.90 (+1.29%) | 1,238.52 (96.07%) |
with_mustache_literal | ✅ (view plot) | 747.55 (+3.35%) | 765.27 (97.68%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
DefaultHasher
with FnvHasher
DefaultHasher
with FnvHasher
DefaultHasher
with FnvHasher
DefaultHasher
tusharmath
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Briefly describe the changes made in this PR.
Issue Reference(s):
Fixes #... (Replace "..." with the issue number)
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>