Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable JS build for all architecture #1963

Merged
merged 2 commits into from
May 15, 2024

Conversation

varshith257
Copy link
Contributor

@varshith257 varshith257 commented May 14, 2024

Summary:
Updated the CI to build Tailcall on all supported platforms without any feature flags

  • Unsupported platforms

  • linux-x64-musl

  • linux-arm64-musl

  • linux-ia32-gnu

  • win32-x64-gnu

  • win32-arm64-msvc

  • win32-ia32-gnu

Issue Reference(s):

Fixes #1869
/claim #1869

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

Copy link

algora-pbc bot commented May 14, 2024

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe/Alipay.

@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label May 14, 2024
@varshith257
Copy link
Contributor Author

varshith257 commented May 14, 2024

@tusharmath @amitksingh1490 Can I get approval for workflows to trigger?

@varshith257
Copy link
Contributor Author

varshith257 commented May 15, 2024

@tusharmath The failing test is due to codecov token. The reason for is as below. We need to add upload token ig

https://docs.codecov.com/docs/adding-the-codecov-token

error - 2024-05-15 08:03:08,161 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 99 seconds."}

@tusharmath tusharmath merged commit c8c9b9f into tailcallhq:main May 15, 2024
27 of 28 checks passed
@varshith257 varshith257 deleted the fix-builds branch May 15, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Enable JS build for all architecture
2 participants