Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to set dedupe globally for io #2036

Merged
merged 54 commits into from
Jun 11, 2024
Merged

feat: ability to set dedupe globally for io #2036

merged 54 commits into from
Jun 11, 2024

Conversation

amitksingh1490
Copy link
Collaborator

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@amitksingh1490 amitksingh1490 added the ci: benchmark Runs benchmarks label May 27, 2024
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 89.65517% with 18 lines in your changes missing coverage. Please review.

Project coverage is 84.15%. Comparing base (e9db251) to head (50521e9).

Files Patch % Lines
src/core/ir/io.rs 81.25% 6 Missing ⚠️
src/core/data_loader/dedupe.rs 97.45% 3 Missing ⚠️
src/core/ir/resolver_context_like.rs 50.00% 3 Missing ⚠️
src/core/path.rs 0.00% 3 Missing ⚠️
tailcall-query-plan/src/execution/executor.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2036      +/-   ##
==========================================
- Coverage   84.18%   84.15%   -0.03%     
==========================================
  Files         212      212              
  Lines       19955    19987      +32     
==========================================
+ Hits        16799    16821      +22     
- Misses       3156     3166      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 27, 2024

🐰Bencher

ReportTue, June 11, 2024 at 08:41:43 UTC
Projecttailcall
Branch2036/merge
Testbedbenchmarking-runner
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
from_json_bench✅ (view plot)7,160,900.00 (+0.65%)7,249,371.44 (98.78%)
group_by✅ (view plot)546.11 (-5.62%)647.69 (84.32%)
input/args.missing✅ (view plot)22.82 (-5.52%)26.96 (84.62%)
input/args.nested.existing✅ (view plot)43.03 (-11.05%)63.38 (67.90%)
input/args.nested.missing✅ (view plot)37.94 (-0.56%)40.54 (93.57%)
input/args.root✅ (view plot)36.81 (-17.60%)60.14 (61.21%)
input/headers.existing✅ (view plot)32.63 (+2.99%)33.70 (96.85%)
input/headers.missing✅ (view plot)32.73 (+6.51%)33.47 (97.79%)
input/value.missing✅ (view plot)23.19 (-1.15%)24.95 (92.94%)
input/value.nested.existing✅ (view plot)41.46 (-0.27%)44.95 (92.24%)
input/value.nested.missing✅ (view plot)37.45 (+2.43%)38.59 (97.05%)
input/value.root✅ (view plot)37.87 (-0.93%)41.56 (91.14%)
input/vars.existing✅ (view plot)7.44 (-5.96%)8.95 (83.15%)
input/vars.missing✅ (view plot)11.44 (+21.76%)12.66 (90.40%)
test_batched_body✅ (view plot)2,599.80 (-99.53%)2,210,256.35 (0.12%)
test_batched_body #2✅ (view plot)1,703,900.00 (-0.29%)1,839,044.36 (92.65%)
test_data_loader✅ (view plot)461,570.00 (-1.71%)487,181.39 (94.74%)
test_handle_request✅ (view plot)153,100.00 (-3.01%)175,688.79 (87.14%)
test_http_execute_method✅ (view plot)17,931.00 (-2.28%)19,494.76 (91.98%)
with_mustache_expressions✅ (view plot)1,119.70 (-4.16%)1,231.18 (90.95%)
with_mustache_literal✅ (view plot)663.06 (-8.31%)775.42 (85.51%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@amitksingh1490 amitksingh1490 changed the title Test3 chore: test3 May 28, 2024
@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label May 28, 2024
@amitksingh1490 amitksingh1490 added the ci: lint Automatically fix the linters issues and make a commit label May 29, 2024
@amitksingh1490 amitksingh1490 marked this pull request as ready for review May 29, 2024 18:02
@amitksingh1490 amitksingh1490 changed the title chore: test3 feat: ability to set dedupe globally for io's May 30, 2024
@amitksingh1490 amitksingh1490 changed the title feat: ability to set dedupe globally for io's feat: ability to set dedupe globally for io May 30, 2024
@amitksingh1490 amitksingh1490 added type: feature Brand new functionality, features, pages, workflows, endpoints, etc. and removed type: chore Routine tasks like conversions, reorganization, and maintenance work. ci: lint Automatically fix the linters issues and make a commit labels May 30, 2024
src/core/async_cache.rs Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jun 4, 2024

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Jun 4, 2024
Copy link

github-actions bot commented Jun 6, 2024

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Jun 6, 2024
Copy link

github-actions bot commented Jun 8, 2024

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jun 8, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jun 10, 2024
@tusharmath tusharmath enabled auto-merge (squash) June 11, 2024 08:26
@amitksingh1490 amitksingh1490 merged commit 864e56a into main Jun 11, 2024
32 of 33 checks passed
@amitksingh1490 amitksingh1490 deleted the test3 branch June 11, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: benchmark Runs benchmarks type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants