Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary boxing #2191

Merged
merged 4 commits into from
Jun 15, 2024
Merged

chore: remove unnecessary boxing #2191

merged 4 commits into from
Jun 15, 2024

Conversation

meskill
Copy link
Contributor

@meskill meskill commented Jun 14, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.19%. Comparing base (ab0b519) to head (fd21e07).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2191   +/-   ##
=======================================
  Coverage   84.18%   84.19%           
=======================================
  Files         212      212           
  Lines       20097    20095    -2     
=======================================
- Hits        16919    16918    -1     
+ Misses       3178     3177    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amitksingh1490 amitksingh1490 added the ci: benchmark Runs benchmarks label Jun 14, 2024
@amitksingh1490 amitksingh1490 added this pull request to the merge queue Jun 14, 2024
Copy link

github-actions bot commented Jun 14, 2024

🐰Bencher

ReportSat, June 15, 2024 at 06:27:38 UTC
Projecttailcall
Branch2191/merge
Testbedbenchmarking-runner
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
from_json_bench✅ (view plot)7,005,800.00 (-1.69%)7,264,479.55 (96.44%)
group_by✅ (view plot)543.60 (-5.59%)645.32 (84.24%)
input/args.missing✅ (view plot)22.80 (-5.23%)26.84 (84.93%)
input/args.nested.existing✅ (view plot)41.81 (-12.67%)62.73 (66.64%)
input/args.nested.missing✅ (view plot)37.48 (-1.68%)40.45 (92.66%)
input/args.root✅ (view plot)36.01 (-18.43%)59.48 (60.53%)
input/headers.existing✅ (view plot)30.39 (-3.99%)33.70 (90.16%)
input/headers.missing✅ (view plot)29.18 (-4.98%)33.49 (87.12%)
input/value.missing✅ (view plot)23.46 (+0.06%)24.91 (94.21%)
input/value.nested.existing✅ (view plot)42.62 (+2.37%)45.17 (94.37%)
input/value.nested.missing✅ (view plot)36.87 (+0.72%)38.61 (95.49%)
input/value.root✅ (view plot)38.15 (-0.14%)41.70 (91.47%)
input/vars.existing✅ (view plot)7.49 (-5.05%)8.92 (83.97%)
input/vars.missing✅ (view plot)9.07 (-4.53%)12.79 (70.93%)
test_batched_body✅ (view plot)2,654.50 (-99.48%)2,130,407.10 (0.12%)
test_batched_body #2✅ (view plot)1,698,900.00 (-0.43%)1,833,597.78 (92.65%)
test_data_loader✅ (view plot)462,260.00 (-1.54%)486,934.29 (94.93%)
test_handle_request✅ (view plot)153,970.00 (-1.98%)174,099.91 (88.44%)
test_http_execute_method✅ (view plot)17,636.00 (-3.59%)19,386.96 (90.97%)
with_mustache_expressions✅ (view plot)1,171.20 (+0.37%)1,229.86 (95.23%)
with_mustache_literal✅ (view plot)763.34 (+5.73%)775.06 (98.49%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@amitksingh1490 amitksingh1490 removed this pull request from the merge queue due to a manual request Jun 14, 2024
@tusharmath tusharmath merged commit 7f57834 into main Jun 15, 2024
32 checks passed
@tusharmath tusharmath deleted the chore/remove-pin branch June 15, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: benchmark Runs benchmarks type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants