-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unnecessary boxing #2191
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2191 +/- ##
=======================================
Coverage 84.18% 84.19%
=======================================
Files 212 212
Lines 20097 20095 -2
=======================================
- Hits 16919 16918 -1
+ Misses 3178 3177 -1 ☔ View full report in Codecov by Sentry. |
amitksingh1490
approved these changes
Jun 14, 2024
|
Report | Sat, June 15, 2024 at 06:27:38 UTC |
Project | tailcall |
Branch | 2191/merge |
Testbed | benchmarking-runner |
Click to view all benchmark results
Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
---|---|---|---|
from_json_bench | ✅ (view plot) | 7,005,800.00 (-1.69%) | 7,264,479.55 (96.44%) |
group_by | ✅ (view plot) | 543.60 (-5.59%) | 645.32 (84.24%) |
input/args.missing | ✅ (view plot) | 22.80 (-5.23%) | 26.84 (84.93%) |
input/args.nested.existing | ✅ (view plot) | 41.81 (-12.67%) | 62.73 (66.64%) |
input/args.nested.missing | ✅ (view plot) | 37.48 (-1.68%) | 40.45 (92.66%) |
input/args.root | ✅ (view plot) | 36.01 (-18.43%) | 59.48 (60.53%) |
input/headers.existing | ✅ (view plot) | 30.39 (-3.99%) | 33.70 (90.16%) |
input/headers.missing | ✅ (view plot) | 29.18 (-4.98%) | 33.49 (87.12%) |
input/value.missing | ✅ (view plot) | 23.46 (+0.06%) | 24.91 (94.21%) |
input/value.nested.existing | ✅ (view plot) | 42.62 (+2.37%) | 45.17 (94.37%) |
input/value.nested.missing | ✅ (view plot) | 36.87 (+0.72%) | 38.61 (95.49%) |
input/value.root | ✅ (view plot) | 38.15 (-0.14%) | 41.70 (91.47%) |
input/vars.existing | ✅ (view plot) | 7.49 (-5.05%) | 8.92 (83.97%) |
input/vars.missing | ✅ (view plot) | 9.07 (-4.53%) | 12.79 (70.93%) |
test_batched_body | ✅ (view plot) | 2,654.50 (-99.48%) | 2,130,407.10 (0.12%) |
test_batched_body #2 | ✅ (view plot) | 1,698,900.00 (-0.43%) | 1,833,597.78 (92.65%) |
test_data_loader | ✅ (view plot) | 462,260.00 (-1.54%) | 486,934.29 (94.93%) |
test_handle_request | ✅ (view plot) | 153,970.00 (-1.98%) | 174,099.91 (88.44%) |
test_http_execute_method | ✅ (view plot) | 17,636.00 (-3.59%) | 19,386.96 (90.97%) |
with_mustache_expressions | ✅ (view plot) | 1,171.20 (+0.37%) | 1,229.86 (95.23%) |
with_mustache_literal | ✅ (view plot) | 763.34 (+5.73%) | 775.06 (98.49%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci: benchmark
Runs benchmarks
type: chore
Routine tasks like conversions, reorganization, and maintenance work.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Briefly describe the changes made in this PR.
Issue Reference(s):
Fixes #... (Replace "..." with the issue number)
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>