Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow union as input types #2221

Merged
merged 8 commits into from
Jun 25, 2024
Merged

feat: allow union as input types #2221

merged 8 commits into from
Jun 25, 2024

Conversation

meskill
Copy link
Contributor

@meskill meskill commented Jun 18, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #1990

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.90%. Comparing base (8a7dd73) to head (68b790f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2221      +/-   ##
==========================================
+ Coverage   85.74%   85.90%   +0.15%     
==========================================
  Files         219      223       +4     
  Lines       21022    21315     +293     
==========================================
+ Hits        18025    18310     +285     
- Misses       2997     3005       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meskill meskill marked this pull request as ready for review June 19, 2024 14:17
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jun 21, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jun 23, 2024
@tusharmath tusharmath enabled auto-merge (squash) June 25, 2024 10:57
@tusharmath tusharmath disabled auto-merge June 25, 2024 10:57
@tusharmath tusharmath merged commit 949a9ca into main Jun 25, 2024
33 checks passed
@tusharmath tusharmath deleted the feat/union-input-type branch June 25, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support config::Union type as input type
2 participants