Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restructure store #2233

Merged
merged 23 commits into from
Jun 23, 2024
Merged

chore: restructure store #2233

merged 23 commits into from
Jun 23, 2024

Conversation

ssddOnTop
Copy link
Member

@ssddOnTop ssddOnTop commented Jun 20, 2024

TODO

  • proper formatting for multiple root nodes in a single request

@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 90.59233% with 27 lines in your changes missing coverage. Please review.

Project coverage is 85.67%. Comparing base (cd21c54) to head (feaa83f).

Files Patch % Lines
src/core/ir/jit/synth.rs 93.78% 11 Missing ⚠️
src/core/ir/jit/store.rs 50.00% 10 Missing ⚠️
src/core/ir/jit/model.rs 83.33% 4 Missing ⚠️
src/core/ir/jit/common/json_placeholder.rs 96.22% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2233      +/-   ##
==========================================
+ Coverage   85.57%   85.67%   +0.10%     
==========================================
  Files         216      219       +3     
  Lines       20760    21046     +286     
==========================================
+ Hits        17765    18031     +266     
- Misses       2995     3015      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the ci: benchmark Runs benchmarks label Jun 20, 2024
@tusharmath tusharmath marked this pull request as ready for review June 21, 2024 04:31
Copy link
Contributor

@tusharmath tusharmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use larger input values for better benchmarks

benches/bench_synth.rs Outdated Show resolved Hide resolved
benches/bench_synth.rs Outdated Show resolved Hide resolved
@tusharmath tusharmath removed the ci: benchmark Runs benchmarks label Jun 22, 2024
@github-actions github-actions bot added the ci: benchmark Runs benchmarks label Jun 22, 2024
Copy link

github-actions bot commented Jun 22, 2024

🐰Bencher

ReportSun, June 23, 2024 at 06:04:27 UTC
Projecttailcall
Branch2233/merge
Testbedbenchmarking-runner
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
from_json_bench✅ (view plot)7,090,500.00 (-0.45%)7,256,877.44 (97.71%)
group_by✅ (view plot)541.12 (-5.22%)639.76 (84.58%)
input/args.missing✅ (view plot)25.87 (+7.27%)27.40 (94.42%)
input/args.nested.existing✅ (view plot)54.28 (+13.48%)62.37 (87.02%)
input/args.nested.missing✅ (view plot)38.40 (+0.72%)40.96 (93.75%)
input/args.root✅ (view plot)51.03 (+15.34%)59.52 (85.74%)
input/headers.existing✅ (view plot)30.32 (-4.16%)33.78 (89.77%)
input/headers.missing✅ (view plot)29.42 (-4.26%)33.60 (87.54%)
input/value.missing✅ (view plot)23.45 (-0.01%)25.00 (93.79%)
input/value.nested.existing✅ (view plot)40.99 (-1.37%)45.08 (90.94%)
input/value.nested.missing✅ (view plot)36.75 (+0.42%)38.67 (95.04%)
input/value.root✅ (view plot)38.02 (-0.29%)41.63 (91.32%)
input/vars.existing✅ (view plot)7.53 (-3.47%)8.75 (86.12%)
input/vars.missing✅ (view plot)12.08 (+24.09%)13.12 (92.12%)
synth_nested✅ (view plot)20,640.00
test_batched_body✅ (view plot)2,656.80 (-99.32%)1,871,963.42 (0.14%)
test_batched_body #2✅ (view plot)1,639,600.00 (-3.72%)1,827,294.43 (89.73%)
test_data_loader✅ (view plot)463,430.00 (-1.23%)486,118.81 (95.33%)
test_handle_request✅ (view plot)152,950.00 (-2.19%)172,552.79 (88.64%)
test_http_execute_method✅ (view plot)17,871.00 (-1.90%)19,304.65 (92.57%)
with_mustache_expressions✅ (view plot)1,161.30 (-0.44%)1,230.63 (94.37%)
with_mustache_literal✅ (view plot)724.81 (+0.51%)775.05 (93.52%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@tusharmath tusharmath removed the ci: benchmark Runs benchmarks label Jun 23, 2024
@tusharmath tusharmath enabled auto-merge (squash) June 23, 2024 06:09
@github-actions github-actions bot added the ci: benchmark Runs benchmarks label Jun 23, 2024
@tusharmath tusharmath merged commit 84e57f2 into main Jun 23, 2024
30 checks passed
@tusharmath tusharmath deleted the chore/new-store branch June 23, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: benchmark Runs benchmarks type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants