Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: types across multiple configs #2234

Merged
merged 8 commits into from
Jun 23, 2024
Merged

fix: types across multiple configs #2234

merged 8 commits into from
Jun 23, 2024

Conversation

shashitnak
Copy link
Contributor

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.69%. Comparing base (2606a1f) to head (9075672).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2234   +/-   ##
=======================================
  Coverage   85.69%   85.69%           
=======================================
  Files         219      219           
  Lines       21039    21043    +4     
=======================================
+ Hits        18029    18033    +4     
  Misses       3010     3010           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shashitnak shashitnak changed the title fix: input types across multiple configs fix: types across multiple configs Jun 20, 2024
src/core/config/config_module.rs Outdated Show resolved Hide resolved
src/core/config/config_module.rs Outdated Show resolved Hide resolved
@tusharmath tusharmath enabled auto-merge (squash) June 23, 2024 08:12
@tusharmath tusharmath disabled auto-merge June 23, 2024 08:12
@tusharmath tusharmath merged commit ff14331 into main Jun 23, 2024
33 checks passed
@tusharmath tusharmath deleted the fix/multiple-configs branch June 23, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants