Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move jit out into core #2264

Merged
merged 1 commit into from
Jun 23, 2024
Merged

refactor: move jit out into core #2264

merged 1 commit into from
Jun 23, 2024

Conversation

tusharmath
Copy link
Contributor

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added ci: benchmark Runs benchmarks type: chore Routine tasks like conversions, reorganization, and maintenance work. labels Jun 23, 2024
@tusharmath tusharmath marked this pull request as ready for review June 23, 2024 12:03
@tusharmath tusharmath removed the ci: benchmark Runs benchmarks label Jun 23, 2024
@tusharmath tusharmath merged commit 2bd8d6c into main Jun 23, 2024
33 checks passed
@tusharmath tusharmath deleted the restructure-jit branch June 23, 2024 12:18
Copy link

🐰Bencher

ReportSun, June 23, 2024 at 12:22:23 UTC
Projecttailcall
Branch2264/merge
Testbedbenchmarking-runner

🚨 1 ALERT: Threshold Boundary Limit exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
input/value.missingLatency (nanoseconds (ns))🚨 (view plot | view alert)29.30 (+24.83%)25.20 (116.28%)

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
from_json_bench✅ (view plot)7,142,500.00 (+0.26%)7,256,177.03 (98.43%)
group_by✅ (view plot)548.76 (-3.64%)637.24 (86.12%)
input/args.missing✅ (view plot)25.54 (+5.89%)27.40 (93.21%)
input/args.nested.existing✅ (view plot)52.91 (+10.78%)62.14 (85.14%)
input/args.nested.missing✅ (view plot)37.51 (-1.52%)40.92 (91.67%)
input/args.root✅ (view plot)51.57 (+16.66%)59.37 (86.86%)
input/headers.existing✅ (view plot)30.36 (-4.02%)33.79 (89.84%)
input/headers.missing✅ (view plot)29.15 (-5.08%)33.62 (86.71%)
input/value.missing🚨 (view plot | view alert)29.30 (+24.83%)25.20 (116.28%)
input/value.nested.existing✅ (view plot)40.27 (-3.06%)45.07 (89.34%)
input/value.nested.missing✅ (view plot)35.29 (-3.54%)38.68 (91.22%)
input/value.root✅ (view plot)38.21 (+0.30%)41.59 (91.88%)
input/vars.existing✅ (view plot)7.47 (-4.29%)8.93 (83.61%)
input/vars.missing✅ (view plot)10.92 (+11.29%)13.29 (82.18%)
synth_nested✅ (view plot)20,953.00 (-0.45%)21,826.88 (96.00%)
test_batched_body✅ (view plot)2,619.80 (-99.26%)1,791,281.96 (0.15%)
test_batched_body #2✅ (view plot)1,661,900.00 (-2.34%)1,825,577.92 (91.03%)
test_data_loader✅ (view plot)461,750.00 (-1.57%)486,058.74 (95.00%)
test_handle_request✅ (view plot)154,170.00 (-1.39%)172,331.02 (89.46%)
test_http_execute_method✅ (view plot)18,094.00 (-0.58%)19,290.09 (93.80%)
with_mustache_expressions✅ (view plot)1,150.20 (-1.39%)1,230.92 (93.44%)
with_mustache_literal✅ (view plot)717.22 (-0.58%)775.56 (92.48%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant