refactor: refactor the resource reader #2290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
| let response = reader.get(&url, headers).await?; | ||
| input_samples.push(Input::Json { url: url.parse()?, response, field_name }); | ||
| let mut request = reqwest::Request::new(reqwest::Method::GET, url.parse()?); | ||
| if let Some(headers_inner) = headers { |
There was a problem hiding this comment.
can we do something better for this else we've to convert the BTreeMap to HeaderMap.
can use TryFrom trait.
tusharmath
reviewed
Jun 27, 2024
src/core/resource_reader.rs
Outdated
| .execute(reqwest::Request::new(reqwest::Method::GET, url)) | ||
| .await?; | ||
|
|
||
| async fn read<T: Into<Resource> + ToString + Send>(&self, file: T) -> anyhow::Result<FileRead> { |
There was a problem hiding this comment.
Suggested change
| async fn read<T: Into<Resource> + ToString + Send>(&self, file: T) -> anyhow::Result<FileRead> { | |
| async fn read<T: Into<Resource> + Send>(&self, file: T) -> anyhow::Result<FileRead> { |
tusharmath
reviewed
Jun 27, 2024
src/core/resource_reader.rs
Outdated
| @@ -16,48 +14,73 @@ pub struct FileRead { | |||
| pub path: String, | |||
| } | |||
|
|
|||
| /// Supported Resources by Resource Reader | |||
| pub enum Resource { | |||
| File(String), | |||
There was a problem hiding this comment.
Suggested change
| File(String), | |
| RawPath(String), |
tusharmath
merged commit a1d5c2e
into
feat/add-support-for-headers-in-request
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Briefly describe the changes made in this PR.
Issue Reference(s):
Fixes #... (Replace "..." with the issue number)
Build & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.Checklist:
<type>(<optional scope>): <title>