chore: compare micro benchmarks #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashitnak
added
ci: benchmark
|
CI should fail if the benchmarks show a performance degradation of greater than 1%
tusharmath
force-pushed
the
compare-benchmarks
branch
from
ddb8e2b
to
f4c3da7
Compare
tusharmath
reviewed
Dec 27, 2023
benches/criterion_compare.rs
Outdated
| } else { | ||
| ((new_value - old_value) / old_value) * 100.0 | ||
| } | ||
| } |
There was a problem hiding this comment.
move this file to /scripts
tusharmath
reviewed
Dec 27, 2023
benches/json_to_md.rs
Outdated
| std::process::exit(1); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
move this file to /scripts
alankritdabral
commented
Dec 28, 2023
tusharmath
reviewed
Dec 28, 2023
.github/workflows/bot.yml
Outdated
| - name: Start Nginx | ||
| run: | | ||
| sudo systemctl start nginx | ||
|
|
There was a problem hiding this comment.
Nginx changes here are not relevant
|
/tip 150$ |
|
🎉🎈 @alankritdabral has been awarded $150! 🎈🎊 |
github-actions
bot
added
the
type: chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Compare Criterion benchmarks with the cache_benchmarks
Added instructions to compare the benchmarks locally
run:
rust-script benches/criterion_compare <benchmarks1.json> <benchmarks2.json> checkto check the degradation in benchmarksrust-script benches/criterion_compare <benchmarks1.json> <benchmarks2.json> tableto get the comparison tablerust-script benches/criterion_compare <benchmarks1.json> <benchmarks2.json>to get the comparison table and then check the degradation.Issue Reference(s):
Fixes #... (Replace "..." with the issue number)
Build & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.Checklist: