Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(init): improve/simplify CLI experience #858

Merged

Conversation

ologbonowiwi
Copy link
Contributor

@ologbonowiwi ologbonowiwi commented Dec 31, 2023

Issue Reference(s):
Fixes #698
/claim #698
/split @neo773

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@algora-pbc algora-pbc bot mentioned this pull request Dec 31, 2023
@ologbonowiwi ologbonowiwi changed the title refactor/#698/improve init experience refactor(init): improve/simplify CLI experience Dec 31, 2023
@ologbonowiwi
Copy link
Contributor Author

@meskill @tusharmath, can I get a review on this one, guys?

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (dbe5e64) 90.14% compared to head (99cd28c) 89.97%.

Files Patch % Lines
src/cli/tc.rs 0.00% 50 Missing ⚠️
src/cli/command.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
- Coverage   90.14%   89.97%   -0.18%     
==========================================
  Files          80       80              
  Lines        8131     8147      +16     
==========================================
  Hits         7330     7330              
- Misses        801      817      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/cli/tc.rs Outdated Show resolved Hide resolved
src/cli/tc.rs Outdated Show resolved Hide resolved
src/cli/tc.rs Outdated Show resolved Hide resolved
src/cli/tc.rs Outdated Show resolved Hide resolved
src/cli/tc.rs Outdated Show resolved Hide resolved
src/cli/tc.rs Outdated Show resolved Hide resolved
src/cli/tc.rs Outdated Show resolved Hide resolved
src/cli/tc.rs Outdated Show resolved Hide resolved
src/cli/tc.rs Outdated Show resolved Hide resolved
docs/operators/call.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Jan 5, 2024
@meskill
Copy link
Contributor

meskill commented Jan 5, 2024

@ologbonowiwi please, update the branch and fix conflicts

Wesley Matos added 2 commits January 6, 2024 09:22
@ologbonowiwi
Copy link
Contributor Author

done @meskill

@meskill meskill merged commit 4e15382 into tailcallhq:main Jan 6, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify init subcommand
4 participants