Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile failure with libc 0.2.90 #35

Closed
bgilbert opened this issue Mar 19, 2021 · 2 comments · Fixed by #36
Closed

Compile failure with libc 0.2.90 #35

bgilbert opened this issue Mar 19, 2021 · 2 comments · Fixed by #36

Comments

@bgilbert
Copy link

rust-lang/libc#2116 made libc::RENAME_EXCHANGE unsigned:

error[E0308]: mismatched types
   --> src/dir.rs:371:13
    |
371 |             libc::RENAME_EXCHANGE)
    |             ^^^^^^^^^^^^^^^^^^^^^ expected `i32`, found `u32`
    |
help: you can convert a `u32` to an `i32` and panic if the converted value doesn't fit
    |
371 |             libc::RENAME_EXCHANGE.try_into().unwrap())
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This was referenced Mar 19, 2021
Merged
Closed
Merged
@lucab lucab mentioned this issue Mar 19, 2021
Closed
cgwalters added a commit to cgwalters/openat that referenced this issue Mar 19, 2021
@cgwalters
dir: Cast RENAME_EXCHANGE back to libc::c_int
42f87fa 
Workaround tailhook#35
AKA rust-lang/libc#2116

Unfortunately since we made this libc::c_int in our
public API, we can't easily change it right now.

Closes: tailhook#35
@cgwalters cgwalters mentioned this issue Mar 19, 2021
Merged
@cgwalters
Copy link
Contributor

PR in #36

@tailhook
Copy link
Owner

Released as v0.1.20

@tailhook tailhook reopened this Mar 19, 2021
facebook-github-bot pushed a commit to facebookincubator/below that referenced this issue Apr 5, 2021
@brianc118 @facebook-github-bot
Update Cargo.lock
e26e4bd 
Summary:
Tried building open source build yesterday on my own machine and
getting errors. For example:
tailhook/openat#35. Let's just update
Cargo.lock again.

Generate with `cargo generate-lockfile`.

Reviewed By: boyuni

Differential Revision: D27540835

fbshipit-source-id: 88465b88219c740f8c2d8885ea539dbad89c9471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dir: Cast RENAME_EXCHANGE back to libc::c_int cgwalters/openat
3 participants
@cgwalters @tailhook @bgilbert