Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node Explorer: files and directories are created with extra backslashes in name #231

Closed
tendstofortytwo opened this issue Sep 20, 2023 · 0 comments · Fixed by #277
Closed

Node Explorer: files and directories are created with extra backslashes in name #231

tendstofortytwo opened this issue Sep 20, 2023 · 0 comments · Fixed by #277

Comments

@tendstofortytwo
Copy link
Contributor

If I create a new directory with spaces in its name:

image

Each space is prepended with a backslash:

image

This isn't just a UI bug, the directory is created with the backslashes in the name.

nsood@manganese:~$ ls -l | grep directory
drwxr-xr-x  2 nsood nsood 4096 Sep 20 09:52 a\ new\ directory

The same thing happens with files as well.
tylersmalley added a commit that referenced this issue Nov 21, 2023
@tylersmalley
File Explorer: Fix issue with spaces in filenames
739a371 
We were escaping spaces while using that value directly in SFTP calls. This caused the escape character (`\`) to be included in the file/directory name. Additionally, if a space was included it would not be able to be deleted as it would issue the delete call to include the escape character.

Closes #231

Signed-off-by: Tyler Smalley <tyler@tailscale.com>
@tylersmalley tylersmalley mentioned this issue Nov 21, 2023
Merged
tylersmalley added a commit that referenced this issue Nov 21, 2023
@tylersmalley
File Explorer: Fix issue with spaces in filenames (#277)
736985d 
We were escaping spaces while using that value directly in SFTP calls.
This caused the escape character (`\`) to be included in the
file/directory name. Additionally, if a space was included it would not
be able to be deleted as it would issue the delete call to include the
escape character.

Closes #231

Signed-off-by: Tyler Smalley <tyler@tailscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

File Explorer: Fix issue with spaces in filenames tailscale-dev/vscode-tailscale
1 participant
@tendstofortytwo