Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimum VS Code version #75

Open
shayne opened this issue Jun 25, 2023 · 1 comment · May be fixed by #88
Open

Minimum VS Code version #75

shayne opened this issue Jun 25, 2023 · 1 comment · May be fixed by #88

Comments

@shayne
Copy link
Contributor

shayne commented Jun 25, 2023

In trying to run the extension on Pop!_OS I ran into an error:

image

Pop promotes the OSS version of Code, which is only at version 1.74.3.

Can we lower the required version?

vscode-tailscale/package.json

Lines 11 to 13 in 4f5e54d

"engines": {
"vscode": "^1.76.0"
},

@shayne
Copy link
Contributor Author

shayne commented Jun 25, 2023

Pop!_OS deb is currently at 1.67.2
image

@shayne shayne mentioned this issue Jun 25, 2023
Merged
shayne added a commit that referenced this issue Jun 29, 2023
@shayne
package.json: change "engines"."vscode" to "^1.58.2"
7916428 
This is ~July 2021 or ~2 years back.

Fixes #75

Signed-off-by: shayne <79330+shayne@users.noreply.github.com>
@shayne shayne linked a pull request Jun 29, 2023 that will close this issue
Draft
shayne added a commit that referenced this issue Jun 29, 2023
@shayne
package.json: change "engines"."vscode" to "^1.58.2"
53fb335 
This is ~July 2021 or ~2 years back.

Fixes #75

Signed-off-by: shayne <79330+shayne@users.noreply.github.com>
@tylersmalley tylersmalley mentioned this issue Jun 29, 2023
Merged
tylersmalley added a commit that referenced this issue Jun 29, 2023
@tylersmalley
package.json: change "engines"."vscode" to "^1.74.0" (#89)
7a627b1 
@shayne verified this is the minimum version supported. 

Related to #75

Signed-off-by: Tyler Smalley <tyler@tailscale.com>
tylersmalley added a commit that referenced this issue Jun 29, 2023
@tylersmalley
package.json: change "engines"."vscode" to "^1.74.0" (#89)
b4c7bcd 
@shayne verified this is the minimum version supported.

Related to #75

Signed-off-by: Tyler Smalley <tyler@tailscale.com>
(cherry picked from commit 7a627b1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

package.json: change "engines"."vscode" to "^1.58.2" tailscale-dev/vscode-tailscale
1 participant
@shayne