Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Snooze" for port disco toast #80

Open
shayne opened this issue Jun 27, 2023 · 1 comment
Open

Add "Snooze" for port disco toast #80

shayne opened this issue Jun 27, 2023 · 1 comment
Assignees
@tendstofortytwo
Labels
help wanted Extra attention is needed

Comments

@shayne
Copy link
Contributor

shayne commented Jun 27, 2023

To prevent port disco toasts from being annoying, we should add a "Snooze" button to the toast that allows you to snooze it for something like "15 minutes", "1 hour". In addition, a "Settings" button takes you to our extension's settings. The extension's settings would have a new setting, something like "Don't show port discovery messages".
This was referenced Jul 5, 2023
Merged
Closed
tylersmalley added a commit that referenced this issue Jul 10, 2023
@marwan-at-work @tylersmalley
Make port discovery optional via settings (#94)
d1e0ef1 
This PR allows users to turn on/off port discovery via the vscode
settings. This should unblock users who don't want to see much noise,
but we can make further enhancements in follow up PRs such as 'snoozing'
or a button in the notification to let them know of this option.

Fixes #21
Updates #80

---------

Signed-off-by: Tyler Smalley <tyler@tailscale.com>
Co-authored-by: Tyler Smalley <tyler@tailscale.com>
@tylersmalley tylersmalley mentioned this issue Sep 19, 2023
Open
@tylersmalley
Copy link
Contributor

There is a PR for a portion of this work at #100 that could be pulled over the line.

@tylersmalley tylersmalley added help wanted Extra attention is needed and removed need-partner-support labels Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tendstofortytwo tendstofortytwo

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tylersmalley @shayne @tendstofortytwo