Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serve/advanced: Remove UI #8

Merged
merged 1 commit into from
Jun 7, 2023
Merged

serve/advanced: Remove UI #8

merged 1 commit into from
Jun 7, 2023

Conversation

tylersmalley
Copy link
Contributor

We're going to iterate on the UI and possibly combine with the simple view. This view was still using messages, so removing it cleans up a lot of old code paths.

@tylersmalley tylersmalley changed the title serve/advanced: Review UI for now serve/advanced: Remove advanced UI for now Jun 7, 2023
We're going to iterate on the UI and possibly combine with the simple view. This view was still using messages, so removing it cleans up a lot of old code paths.

Signed-off-by: Tyler Smalley <tyler@tailscale.com>
Copy link
Contributor

@marwan-at-work marwan-at-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏼

@tylersmalley tylersmalley changed the title serve/advanced: Remove advanced UI for now serve/advanced: Remove UI Jun 7, 2023
@tylersmalley tylersmalley merged commit 86e8412 into main Jun 7, 2023
2 checks passed
@tylersmalley tylersmalley deleted the tyler/rm-serve-advanced branch June 7, 2023 15:41
tylersmalley added a commit that referenced this pull request Jun 7, 2023
We're going to iterate on the UI and possibly combine with the simple
view. This view was still using messages, so removing it cleans up a lot
of old code paths.

Signed-off-by: Tyler Smalley <tyler@tailscale.com>
(cherry picked from commit 86e8412)
@tylersmalley
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
release-branch/v0.4

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

tylersmalley added a commit that referenced this pull request Jun 7, 2023
# Backport

This will backport the following commits from `main` to
`release-branch/v0.4`:
- [serve/advanced: Remove UI
(#8)](#8)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)
tylersmalley added a commit that referenced this pull request Jun 13, 2023
We're going to iterate on the UI and possibly combine with the simple
view. This view was still using messages, so removing it cleans up a lot
of old code paths.

Signed-off-by: Tyler Smalley <tyler@tailscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants