add timeout on steps with network I/O #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
well I guess that answers that question... you can't specify timeout-minutes in actions.yml https://github.com/tailscale/github-action/actions/runs/5414970481 |
DentonGentry
approved these changes
Jun 29, 2023
DentonGentry
suggested changes
Jun 29, 2023
|
Yeah, I don't think we can do this in actions.yml. timeout isn't mentioned in their docs, but I was hoping it would still work. Looks like users will need to set it on their own. Maybe we just update the README to suggest a default value. |
|
or maybe we use the |
willnorris
changed the title
DentonGentry
approved these changes
Jun 29, 2023
|
I imagine curl has a timeout argument as well. |
Set a reasonable timeout to prevent jobs from hanging for hours (#50). 5 minutes is way longer than should ever be necessary, but accounts for intermittent networking issues on either the actions runner or the Tailscale package or control server. Users can always set a shorter timeout on their own action step. Fixes #50 Signed-off-by: Will Norris <will@tailscale.com>
willnorris
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set a reasonable timeout to prevent jobs from hanging for hours (#50). 5 minutes is way longer than should ever be necessary, but accounts for intermittent networking issues on either the actions runner or the Tailscale package or control server. Users can always set a shorter timeout on their own action step.
Fixes #50