Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache actions and separate binary management to be compatible with caching #90

Closed
wants to merge 1 commit into from

Conversation

zonorti
Copy link

@zonorti zonorti commented Aug 29, 2023

This PR addresses issues #87 #88 #89
I added Cache@v3 action that checks for already downloaded binaries in the cache and reports to the download step if it should download.
If binaries are not cached - download would happen and they would be saved to ${{ runner.temp }}/tailscale_${{inputs.version}}_${{env.TS_ARCH}}/ where cache action would copy from at the end of the workflow in cache post-action.

To try it out one can use uses: zonorti/github-action@github_cache, but beware - it would stop working after this PR is merged and branch is deleted.

All feedback is welcome 👂

…th caching

Signed-off-by: Sergey Melnik <sergey@klang-games.com>
@zonorti
Copy link
Author

zonorti commented Sep 26, 2023

After experimenting with this action more I figured out that it still stays at 10 seconds of runtime, therefore caching makes no sense, unless CDN starts failing again.
I'll close this PR therefore.

@zonorti zonorti closed this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant