Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: option to disable HTTPS #107

Closed
tiesmaster opened this issue Jan 14, 2024 · 1 comment · Fixed by #113
Closed

Feature request: option to disable HTTPS #107

tiesmaster opened this issue Jan 14, 2024 · 1 comment · Fixed by #113

Comments

@tiesmaster
Copy link

It was really awesome to see that HTTPS was getting added in #99, to resolve #29, which helps workflows for some people. However, I'd rather have HTTPS turned off. I've configured my browser to ignore the missing HTTPS, and don't use the opensearch xml feature. One of the downsides of having this turned on, is that golink needs to acquire a new cert on initial deployment, which takes time to get the service live (not a big problem, but also a bit annoying).

I know you can turn off HTTPS from the Admin console, which I did, as I don't use the HTTPS feature of Tailscale atm. However, I'd like to be able to turn this on in the future, and don't get golink breaking on this, which I'll have completely forgotten about in a couple of months.

Yeah, I know, I guess XKCD 1172 is applicable ;) Though, I am willing to contribute a PR, which I'd gladly do. Would you be willing to accept a PR to add support for a configuration flag to override this behavior?

@noncombatant
Copy link
Contributor

Hello @tiesmaster! Sure, if you send a PR, we'll take a look. Thanks! :)

willnorris added a commit that referenced this issue Mar 2, 2024
willnorris added a commit that referenced this issue Mar 2, 2024
Fixes #107

Signed-off-by: Will Norris <will@tailscale.com>
willnorris added a commit that referenced this issue Mar 4, 2024
Fixes #107

Signed-off-by: Will Norris <will@tailscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants