go.mod: update tailscale.com to v1.56.1 #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creachadair
force-pushed
the
mjf/update-ts
branch
from
e3dcfc3
to
6089be9
Compare
Previous versions flag a potential security fix in the admin panel. Updates #96 Signed-off-by: M. J. Fromberger <fromberger@tailscale.com>
creachadair
force-pushed
the
mjf/update-ts
branch
from
28a422e
to
3f3b37d
Compare
willnorris
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
We don't specifically need to track HEAD, but I recall running into issues when we imported this into corp with Go module versioning algorithm when comparing the v1.1.1-... versions (which we pretty much always have in corp) with higher values likev1.56. It might also have been user error on my part. So it's probably worth going ahead and trying this, and if it doesn't play nice in corp, we can always bump it forward by a single commit or something if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous versions flag a potential security fix in the admin panel.
It wasn't obvious to me that we need to track HEAD, so I chose the latest
released tag. But if you prefer we track HEAD I can update it accordingly.
Updates #deps
Signed-off-by: M. J. Fromberger fromberger@tailscale.com