Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add expiry to key capabilities #34

Merged
merged 1 commit into from
Nov 3, 2022
Merged

add expiry to key capabilities #34

merged 1 commit into from
Nov 3, 2022

Conversation

dizzzan
Copy link
Contributor

@dizzzan dizzzan commented Nov 3, 2022

Need key expiry in the terraform provider, and I saw it was not yet added to the client pkg, but is available in the API.
Will open separate PR for terraform provider, if this is approved.
Thanks!

@DentonGentry
Copy link
Contributor

This repo and the terraform repo require signed commits using either GPG or SSH keys. Are you set up to do that? If not, I can generate a PR with this change and sign it.

@dizzzan
Copy link
Contributor Author

dizzzan commented Nov 3, 2022

This repo and the terraform repo require signed commits using either GPG or SSH keys. Are you set up to do that? If not, I can generate a PR with this change and sign it.

Ah, just noticed that, sorry. I don't have signing set up on this computer. I can amend the PR later (I think pushing a new signed commit will suffice?), but feel free to generate a separate one instead. I also just created tailscale/terraform-provider-tailscale#175 which will have the same issue :/

@dizzzan
Copy link
Contributor Author

dizzzan commented Nov 3, 2022

@DentonGentry pushed a signed commit, but it seems that didn't pass the check.

@DentonGentry
Copy link
Contributor

There are two commits in this PR and the first is not signed, so it is rejected. I think you want to remove the second, signing commit: git reset --hard HEAD^1

Then sign the first commit: git commit --amend -S

Then force push it to the PR: git push -f

@dizzzan
Copy link
Contributor Author

dizzzan commented Nov 3, 2022

Bingo, thanks :)

@DentonGentry DentonGentry merged commit 84f6c03 into tailscale:main Nov 3, 2022
@davidsbond
Copy link
Collaborator

Looks like this field has been added in the incorrect place based on #35 and the API documentation. Have added an example here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants